CRIU: correct type of pool elements in instanceObjects #16548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'clazz' field of a J9Object isn't generally wide enough to properly
capture an object pointer: use j9object_t instead. This issue was
highlighted by a couple of cast errors in builds configured using
"--with-mixedrefs=no":
CRIUHelpers.cpp:195:52: error: cast to pointer from integer of different
size [-Werror=int-to-pointer-cast]
CRIUHelpers.cpp:334:44: error: cast from 'j9object_t {aka J9Object*}' to
'j9objectclass_t {aka unsigned int}' loses precision [-fpermissive]
Also add missing include directory required in UMA builds.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
tajila
approved these changes
Jan 12, 2023
|
Jenkins test sanity xlinux jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clazzfield of aJ9Objectisn't generally wide enough to properly capture an object pointer: usej9object_tinstead. This issue was highlighted by a couple of cast errors in builds configured using--with-mixedrefs=no:Also add missing include directory required in UMA builds.